physlr-make: update rules to reflect new features#141
Merged
Conversation
Contributor
|
Can you rebase this on master?? |
Contributor
Author
|
Yeah I forgot to update this branch before pushing. EDIT: done |
lcoombe
reviewed
Jan 16, 2020
lcoombe
reviewed
Jan 16, 2020
Merged
a778497 to
d9a3b9e
Compare
lcoombe
reviewed
Jan 27, 2020
aafshinfard
reviewed
Jan 27, 2020
lcoombe
approved these changes
Jan 27, 2020
Collaborator
|
@jowong4 |
Collaborator
|
there we have bug |
Contributor
Author
|
@afshinfard Are the new changes ok with you? |
Collaborator
Yes, prefect. Thanks. |
Collaborator
|
sorry, just found another refer to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains updates that I missed when I updated the physlr-make file in the previous PRs #131 #140 . This PR also contains change to physlr-split-minimizers to work with
ext.mol.tsvfiles.